Popover: focus management for dialog role by dmlvr · Pull Request #34413 · DevExpress/DevExtreme

dmlvr · 2026-07-21T14:39:41Z

No description provided.

…ontent_reading' into dmlvr-feature/26_2_popover_support_content_reading

…up edge case)

Raushen · 2026-07-28T17:57:43Z

+      if (!$first) {
+        // @ts-expect-error is should can get function as callback
+        const isCurrentTabbable = $currentElement?.is(selectors.tabbable);
+        const isCurrentNotOverlay = $currentElement?.get(0) !== this._$content?.get(0);


Can we include overlay selector in the previous one:

$currentElement .is(selectors.tabbable) .not(overlayId);

?

Raushen · 2026-07-28T17:58:35Z

+      if (!$last) {
+        // @ts-expect-error is should can get function as callback
+        const isReverseTabbable = $reverseElement?.is(selectors.tabbable);
+        const isReverseNotOverlay = $reverseElement?.get(0) !== this._$content?.get(0);


The same comment about selector

Raushen · 2026-07-28T18:14:53Z

+  }
+
+  _restoreTargetFocus(): void {
+    const $targets = this._getAriaDescriptionTargets();


We can have only one target. We can apply changes from this comment.

Raushen · 2026-07-28T18:22:04Z

+    }
+  }
+
+  _forceFocusLost(): void {


Please check base method. May we can move there this logic.
Also please check what exactly base method do and why.

Please check base method. Also please check what exactly base method do and why.

The base Overlay._forceFocusLost() checks if the currently focused element is inside the overlay content (this._$content) and blurs (resets) it if so. This prevents focus from being trapped on hidden/invisible elements when the overlay closes, which would break keyboard navigation.

May we can move there this logic?

No. The base Overlay class lacks the role-awareness (_getEffectiveAriaRole()) and target resolution mechanics (_getAriaDescriptionTargets()) that Popover uses to identify and refocus its trigger element.

Raushen · 2026-07-28T18:23:50Z

@@ -890,6 +938,10 @@ class Popover<
  }

  _dispose(): void {
+    const { visible } = this.option();
+    if (visible && this._getEffectiveAriaRole() === 'dialog') {
+      this._restoreTargetFocus();


Should we check if we have focus inside?

Raushen · 2026-07-28T18:25:19Z

@@ -111,6 +111,8 @@ export interface PopoverProperties extends Omit<Properties,
  _overlayContentRole?: string;

  _describeTarget?: boolean;
+
+  _preventDialogFocus?: boolean;


How about _preventDialogContainerFocus?

…r-feature/26_2_popover_support_content_reading Signed-off-by: Dmitry Lavrinovich <52966626+dmlvr@users.noreply.github.com>

…github.com:dmlvr/DevExtreme into dmlvr-feature/26_2_popover_support_content_reading

dmlvr added 2 commits July 21, 2026 15:06

add some more popover tests

7c31784

move and return focus for dialog role

f793e3c

dmlvr self-assigned this Jul 21, 2026

dmlvr added the 26_2 label Jul 21, 2026

dmlvr changed the title ~~Dmlvr feature/26 2 popover support content reading~~ Popover: support content reading on opening Jul 21, 2026

dmlvr changed the title ~~Popover: support content reading on opening~~ Popover: move focus to role dialog and return to target, add default localization role when it doesn't specified Jul 21, 2026

Merge remote-tracking branch 'upstream/feature/26_2_popover_support_c…

8010fa2

…ontent_reading' into dmlvr-feature/26_2_popover_support_content_reading

dmlvr force-pushed the dmlvr-feature/26_2_popover_support_content_reading branch from 0e86e91 to 8010fa2 Compare July 22, 2026 11:07

dmlvr changed the title ~~Popover: move focus to role dialog and return to target, add default localization role when it doesn't specified~~ Popover: move focus to role dialog and return to target Jul 22, 2026

fix after merging

a17511a

dmlvr force-pushed the dmlvr-feature/26_2_popover_support_content_reading branch from 7242766 to a17511a Compare July 22, 2026 12:58

dmlvr changed the title ~~Popover: move focus to role dialog and return to target~~ Popover: focus management for dialog role Jul 22, 2026

update _syncFocusOptions

d9aa676

dmlvr force-pushed the dmlvr-feature/26_2_popover_support_content_reading branch 2 times, most recently from 55c6f73 to d7d5b55 Compare July 23, 2026 07:33

dmlvr marked this pull request as ready for review July 23, 2026 08:12

dmlvr requested a review from a team as a code owner July 23, 2026 08:12

pharret31 reviewed Jul 23, 2026

View reviewed changes

Comment thread packages/devextreme/js/__internal/ui/popover/popover.ts Outdated

refactoring

5f6187d

dmlvr force-pushed the dmlvr-feature/26_2_popover_support_content_reading branch from d7d5b55 to 5f6187d Compare July 23, 2026 13:46

dmlvr added 3 commits July 23, 2026 16:48

fix by review comment

41c93ba

update tabindex for overlay

b81cd6d

add internal Option to prevent focus management for dialog role (Look…

cd436bd

…up edge case)

dmlvr force-pushed the dmlvr-feature/26_2_popover_support_content_reading branch from 42cfdc2 to 5953dba Compare July 27, 2026 16:09

return focus management in Popover

be5e944

dmlvr force-pushed the dmlvr-feature/26_2_popover_support_content_reading branch from d6ab547 to be5e944 Compare July 28, 2026 14:26

dmlvr added 2 commits July 28, 2026 18:33

leftovers

19cd3f5

fix for appointment tooltip integration

42151cd

dmlvr force-pushed the dmlvr-feature/26_2_popover_support_content_reading branch from 88ad727 to 42151cd Compare July 28, 2026 16:46

Raushen reviewed Jul 28, 2026

View reviewed changes

Raushen requested a review from a team July 28, 2026 19:14

dmlvr added 3 commits July 29, 2026 14:16

fix after review

a4e8d51

fix notexpected behavior

a29cb52

fix _findTabbableBounds

c76bcc7

dmlvr added the skip-cache label Jul 29, 2026

dmlvr closed this Jul 29, 2026

dmlvr reopened this Jul 29, 2026

leftovers

6322577

dmlvr requested a review from a team as a code owner July 29, 2026 14:26

dmlvr and others added 3 commits July 29, 2026 17:27

Merge branch 'feature/26_2_popover_support_content_reading' into dmlv…

ac47eaa

…r-feature/26_2_popover_support_content_reading Signed-off-by: Dmitry Lavrinovich <52966626+dmlvr@users.noreply.github.com>

linter

3f152f7

Merge branch 'dmlvr-feature/26_2_popover_support_content_reading' of …

3e348eb

…github.com:dmlvr/DevExtreme into dmlvr-feature/26_2_popover_support_content_reading

dmlvr merged commit 8e0f3d5 into DevExpress:feature/26_2_popover_support_content_reading Jul 29, 2026
97 of 99 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Popover: focus management for dialog role - #34413

Popover: focus management for dialog role#34413
dmlvr merged 19 commits into
DevExpress:feature/26_2_popover_support_content_readingfrom
dmlvr:dmlvr-feature/26_2_popover_support_content_reading

dmlvr commented Jul 21, 2026

Uh oh!

Uh oh!

Raushen Jul 28, 2026

Uh oh!

Raushen Jul 28, 2026

Uh oh!

Raushen Jul 28, 2026 •

edited

Loading

Uh oh!

Raushen Jul 28, 2026

Uh oh!

dmlvr Jul 29, 2026 •

edited

Loading

Uh oh!

Raushen Jul 28, 2026

Uh oh!

Raushen Jul 28, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

dmlvr commented Jul 21, 2026

Uh oh!

Uh oh!

Raushen Jul 28, 2026

Choose a reason for hiding this comment

Uh oh!

Raushen Jul 28, 2026

Choose a reason for hiding this comment

Uh oh!

Raushen Jul 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Raushen Jul 28, 2026

Choose a reason for hiding this comment

Uh oh!

dmlvr Jul 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Raushen Jul 28, 2026

Choose a reason for hiding this comment

Uh oh!

Raushen Jul 28, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Raushen Jul 28, 2026 •

edited

Loading

dmlvr Jul 29, 2026 •

edited

Loading